Fixed crash in GtkLockButton if a button with permission set to NULL is clicked.
authorJuan Pablo Ugarte <juanpablougarte@gmail.com>
Fri, 25 Apr 2014 22:18:28 +0000 (19:18 -0300)
committerMatthias Clasen <mclasen@redhat.com>
Sat, 26 Apr 2014 02:13:56 +0000 (22:13 -0400)
https://bugzilla.gnome.org/show_bug.cgi?id=728992

gtk/gtklockbutton.c

index 6b051d1be1be27c4a433bdabc7e8e8c654911835..d0c973b8ef5b97bafa09e06b5dde5580a5ba5c53 100644 (file)
@@ -451,8 +451,10 @@ gtk_lock_button_clicked (GtkButton *button)
 {
   GtkLockButtonPrivate *priv = GTK_LOCK_BUTTON (button)->priv;
 
-  /* if we already have a pending interactive check, then do nothing */
-  if (priv->cancellable != NULL)
+  /* if we already have a pending interactive check or permission is not set,
+   * then do nothing
+   */
+  if (priv->cancellable != NULL || priv->permission == NULL)
     return;
 
   if (g_permission_get_allowed (priv->permission))